fix: adapt to new libnvme nvme.ctrl() dict-based constructor#487
Merged
martin-belanger merged 1 commit intolinux-nvme:mainfrom Apr 21, 2026
Merged
Conversation
martin-belanger
force-pushed
the
fix-for-new-libnvme
branch
2 times, most recently
from
22ccd68 to
6f5be68
Compare
The libnvme Python bindings changed nvme.ctrl() to accept a single dict instead of individual keyword arguments. Consolidate _get_cfg() to build the complete parameter dict (transport ID fields + fabrics config), then pass it directly to nvme.ctrl(). The connect() call no longer takes a cfg argument. Also fix dhchap_key -> dhchap_ctrl_key to match the renamed property in the new bindings (the old name silently created a shadow Python attribute instead of calling the C setter). Signed-off-by: Martin Belanger <Martin.Belanger@dell.com> Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
martin-belanger
force-pushed
the
fix-for-new-libnvme
branch
from
6f5be68 to
d561432
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
==========================================
+ Coverage 60.71% 60.77% +0.06%
==========================================
Files 16 16
Lines 2612 2616 +4
==========================================
+ Hits 1586 1590 +4
Misses 1026 1026 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libnvme Python bindings changed nvme.ctrl() to accept a single dict instead of individual keyword arguments. Consolidate _get_cfg() to build the complete parameter dict (transport ID fields + fabrics config), then pass it directly to nvme.ctrl(). The connect() call no longer takes a cfg argument.
Also fix dhchap_key -> dhchap_ctrl_key to match the renamed property in the new bindings (the old name silently created a shadow Python attribute instead of calling the C setter).
Assisted-by: Claude Sonnet 4.6 noreply@anthropic.com